Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glib: Re-introduce an event propagation specific type #1144

Merged
merged 3 commits into from
Aug 1, 2023
Merged

glib: Re-introduce an event propagation specific type #1144

merged 3 commits into from
Aug 1, 2023

Conversation

bilelmoussaoui
Copy link
Member

As the semantics of ControlFlow don't match 1:1 with the event propagations See gtk-rs/gtk4-rs#1435

Would still need a change on gir's side as well as a regen + yanking the releases & redoing them..............................

This was referenced Jul 25, 2023
Closed
Merged
bilelmoussaoui
bilelmoussaoui commented Jul 25, 2023
View reviewed changes
glib/src/signal.rs Outdated Show resolved Hide resolved
andy128k
andy128k reviewed Jul 25, 2023
View reviewed changes
glib/src/signal.rs Outdated Show resolved Hide resolved
@bilelmoussaoui
glib: Re-introduce an event propagation specific type
c19be37 
As the semantics of ControlFlow don't match 1:1 with the event
propagations
See gtk-rs/gtk4-rs#1435
@bilelmoussaoui bilelmoussaoui added the needs-backport PR needs backporting to the current stable branch label Aug 1, 2023
@bilelmoussaoui bilelmoussaoui merged commit 286475b into master Aug 1, 2023
46 checks passed
@bilelmoussaoui bilelmoussaoui deleted the bilelmoussaoui/fix-mess branch August 1, 2023 12:51
@bilelmoussaoui bilelmoussaoui added backported PR was backported to the current stable branch and removed needs-backport PR needs backporting to the current stable branch labels Aug 1, 2023
gstreamer-github pushed a commit to sdroege/gst-plugin-rs that referenced this pull request Aug 2, 2023
@fengalin
utils: fix further to glib change ControlFlow -> Propagation
10902c0 
See: gtk-rs/gtk-rs-core#1144
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1292>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awused awused awused left review comments

@andy128k andy128k andy128k left review comments

Assignees
No one assigned
Labels
backported PR was backported to the current stable branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bilelmoussaoui @andy128k @awused